Mute flaky tests - S3RemoteStoreIT #17642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Singh <[email protected]>
ashking94
requested review from
anasalkouz,
andrross,
bugmakerrrrrr,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17642 +/- ##
============================================
+ Coverage 72.44% 72.51% +0.07%
- Complexity 65732 65771 +39
============================================
Files 5311 5311
Lines 305011 305011
Branches 44232 44232
============================================
+ Hits 220969 221189 +220
+ Misses 65967 65716 -251
- Partials 18075 18106 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kotwanikunal
approved these changes
Mar 20, 2025
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-17642-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ebd743a50cd7162f1552568c367b60dea077774e
# Push it to GitHub
git push --set-upstream origin backport/backport-17642-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
bzhangam
pushed a commit
to bzhangam/OpenSearch
that referenced
this pull request
Mar 25, 2025
Signed-off-by: Ashish Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR mutes the test class S3RemoteStoreIT as there is some flakiness observed in the tests. The test run time is high due to actual calls being made to S3. I am planning to fix the tests in a follow up PR and run the tests for 1000+ iterations. I have notice each iteration take around 10-15 mins with my setup. For now, this will mute the tests in S3RemoteStoreIT class.
Check List
[ ] Functionality includes testing.[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.